Remove orphan entries from Gradle version catalog#4325
Remove orphan entries from Gradle version catalog#4325janhoy wants to merge 1 commit intoapache:mainfrom
Conversation
Remove 7 library entries and 3 version keys that are neither referenced in any build file nor present in any resolved dependency graph (verified against all Gradle lock files): Libraries removed: - prometheus-simpleclient / prometheus-simpleclient-httpserver (old Prometheus Java client, superseded by prometheus-metrics-*) - junit-jupiter aggregate (org.junit.jupiter:junit-jupiter v6.0.3; junit-jupiter-api v5.6.2 still arrives transitively via randomizedtesting) - apache-commons-configuration2 - apache-curator-recipes - apache-log4j-jul - dropwizard-metrics-servlets (metrics-jakarta-servlets) Version keys removed (exclusive to the above libraries): - prometheus-simpleclient - junit-jupiter - apache-commons-configuration2 All 28 @keep transitive-alignment entries were verified against lock files and confirmed still needed; they are unchanged.
|
How did you figure this out? Someday I bet we have a whole set of prompts that are part of our build that are "Go look for this issue and tell me if you see it" ;-). It would be nice if some of these types of things just were part of our tooling or docs ;-). I love what you are doing with prompts etc around build tooling. |
|
I suspect @HoustonPutman added curator-recipes speculatively. It's a shame we only still only use curator for the base framework since the real gold there is the recipes. |
I have another PR to add some prompts in dev-docs/. I could share the prompt I used here as well. Claude spent perhaps 10 mins resolving and cross checking all deps with the gradle lock files. I’m sure we could ask AI to build us a py script that does the same job in 30 seconds… Edit: Here's the prompt I used:
|
Prunes 7 library entries and 3 version keys from
gradle/libs.versions.tomlthat are dead weight: not referenced in any build file and not present in any resolved dependency graph (verified against all 37 Gradle lock files).No JAR is added to or removed from the shipped distribution.
One benefit other than cleanup is that renovatebot won't have to bother upgrading stuff we don't use :)
What was removed
prometheus-simpleclient+prometheus-simpleclient-httpserverio.prometheus:simpleclient), fully superseded byio.prometheus:prometheus-metrics-*which is already in usejunit-jupiterorg.junit.jupiter:junit-jupiter:6.0.3is not used;junit-jupiter-api:5.6.2still arrives transitively viarandomizedtestingand is unaffectedapache-commons-configuration2apache-curator-recipescurator-clientandcurator-frameworkare used;curator-recipesis notapache-log4j-juldropwizard-metrics-servlets(metrics-jakarta-servlets)dropwizard-metrics-coreandmetrics-jetty12-ee10are used