Fix docker-compose quickstart for Horizon UI and OAP healthcheck#13899
Open
wu-sheng wants to merge 2 commits into
Open
Fix docker-compose quickstart for Horizon UI and OAP healthcheck#13899wu-sheng wants to merge 2 commits into
wu-sheng wants to merge 2 commits into
Conversation
Addresses apache/skywalking discussion #13896: - OAP healthcheck used `curl http://localhost:12800/internal/l7check`, but the eclipse-temurin JRE image ships no curl/wget/nc. Probe the query port with bash's built-in /dev/tcp instead, and widen start_period to 90s so BanyanDB schema install doesn't burn the retry budget. - Horizon UI listens on 8081 inside the container, not 8080; fix the port mapping (8080:8081). - The Horizon image takes its OAP URLs and login users ONLY from a mounted config file, not env vars. Drop the non-existent SW_OAP_ADDRESS / SW_ADMIN_ADDRESS / SW_ZIPKIN_ADDRESS vars and mount docker/horizon.yaml. - New docker/horizon.yaml: server.host 0.0.0.0 (the example config ships 127.0.0.1, which binds container-loopback only and 503s from the host), oap query/admin/zipkin URLs pointed at the compose `oap` service, and a demo admin/admin local login.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix docker-compose quickstart issues reported in #13896
The docker-compose quickstart had three problems that surfaced when a user tried the Horizon UI with a mounted
horizon.yaml:curl, which isn't present in theeclipse-temurinJRE image — the healthcheck never ran. Replaced with bash's built-in/dev/tcpport probe (no extra binary), and widenedstart_periodto90sso BanyanDB schema install during boot doesn't consume the retry budget.8081inside the container, but compose mapped8080:8080. Fixed to8080:8081.SW_OAP_ADDRESS/SW_ADMIN_ADDRESS/SW_ZIPKIN_ADDRESS). The image reads OAP URLs and login users only from its config file. Now mounts a newdocker/horizon.yamlwithserver.host: 0.0.0.0(the upstream example ships127.0.0.1, which binds container-loopback only and 503s from the host — the original report), OAP query/admin/zipkin URLs pointed at the composeoapservice, and a demoadmin/adminlocal login.Explain briefly why the bug exists and how to fix it.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes When using the horizon.yaml configuration file, the access results in a 503 error. #13896.
Update the
CHANGESlog.