Skip to content

[fix][client-cpp] modern boost cancel method without args#561

Open
daeho-ro wants to merge 1 commit intoapache:mainfrom
daeho-ro:boost-fix
Open

[fix][client-cpp] modern boost cancel method without args#561
daeho-ro wants to merge 1 commit intoapache:mainfrom
daeho-ro:boost-fix

Conversation

@daeho-ro
Copy link
Copy Markdown
Contributor

Fixes #560

Motivation

Build failed with modern boost 1.78+, so fix method signature for it.

Modifications

.cancel has no signature for boost 1.78+

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why) : quite simple change for external library not pulsar.

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@lhotari lhotari requested a review from BewareMyPower March 30, 2026 17:02
Copy link
Copy Markdown
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use cancelTimer in lib/AsioTimer.h instead

@BewareMyPower
Copy link
Copy Markdown
Contributor

It's interesting that the main branch depends on Boost.Asio 1.90 or Asio 1.32, but CI all passed. Maybe it's because ASIO_NO_DEPRECATED is not defined by default?

You can try building the project via vcpkg

@daeho-ro
Copy link
Copy Markdown
Contributor Author

daeho-ro commented Apr 1, 2026

I am not sure this is a correct usage, but anyway tried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Build error with Boost 1.90.0

2 participants