fix(plc4py/umas): resolve Python 3.12+ SyntaxWarnings in UmasTag#2535
Open
Abdylreshit wants to merge 1 commit intoapache:developfrom
Open
fix(plc4py/umas): resolve Python 3.12+ SyntaxWarnings in UmasTag#2535Abdylreshit wants to merge 1 commit intoapache:developfrom
Abdylreshit wants to merge 1 commit intoapache:developfrom
Conversation
- Use raw string for regex pattern (fixes invalid escape sequence '\[') - Replace 'is not 0' with '!= 0' for int comparison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three
SyntaxWarningmessages emitted by Python 3.12+ inplc4py/drivers/umas/UmasTag.py:\[in the regex_ADDRESS_PATTERN— converted the string literal to a raw string.len(...) is not 0— replaced with!= 0. Comparingintwithis/is notis unreliable (works only by CPython small-int caching) and the behavior is deprecated.Test plan
pytestpasses (77 passed, 36 xfailed — same as before, now with 0 warnings)