[spark] Add _ROW_ID existing check before adding _ROW_ID#7601
Draft
XiaoHongbo-Hope wants to merge 5 commits into
Draft
[spark] Add _ROW_ID existing check before adding _ROW_ID#7601XiaoHongbo-Hope wants to merge 5 commits into
XiaoHongbo-Hope wants to merge 5 commits into
Conversation
XiaoHongbo-Hope
force-pushed
the
spark_row_id_fix
branch
from
4d34127 to
07053f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When a table has row-tracking.enabled=true, querying its $row_tracking system table (e.g., SELECT *
FROM table$row_tracking) throws:
IllegalArgumentException: Row tracking field name '_ROW_ID' conflicts with existing field names.This PR fix duplicate
_ROW_IDfield addition inBaseScan.tableRowTypewhen reading from tables whoserowType()already contains_ROW_ID(e.g.,$row_trackingsystem table).Tests
Covered by existing
RowTrackingTestcases.