Skip to content

HDDS-14606. Move dependency on slf4j-reload4j to runnable modules#9787

Merged
adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai:HDDS-14606
Feb 26, 2026
Merged

HDDS-14606. Move dependency on slf4j-reload4j to runnable modules#9787
adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai:HDDS-14606

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

hdds-common has runtime dependency on slf4j-reload4j, which leaks logger implementation into dependent projects. It should be declared only in runnable modules (e.g. ozone-tools, hdds-server-scm, etc.). slf4j-reload4j should be changed to test scope for other modules.

https://issues.apache.org/jira/browse/HDDS-14606

How was this patch tested?

Maven dependency tree. Examples:

[INFO] --- dependency:3.9.0:tree (default-cli) @ ozone-client ---
...
[INFO] \- org.slf4j:slf4j-reload4j:jar:2.0.17:test
...

[INFO] --- dependency:3.9.0:tree (default-cli) @ ozone-cli-shell ---
...
[INFO] +- org.slf4j:slf4j-reload4j:jar:2.0.17:runtime

[INFO] --- dependency:3.9.0:tree (default-cli) @ ozone-manager ---
...
[INFO] +- org.slf4j:slf4j-reload4j:jar:2.0.17:runtime

CI:
https://github.com/adoroszlai/ozone/actions/runs/22145027635

@adoroszlai adoroszlai self-assigned this Feb 18, 2026
@adoroszlai adoroszlai added the build Pull request that modifies the build process label Feb 18, 2026
Copy link
Contributor

@ashishkumar50 ashishkumar50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adoroszlai for the change, LGTM.

@adoroszlai adoroszlai merged commit 494b31e into apache:master Feb 26, 2026
44 checks passed
@adoroszlai adoroszlai deleted the HDDS-14606 branch February 26, 2026 08:17
@adoroszlai
Copy link
Contributor Author

Thanks @ashishkumar50, @yandrey321 for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Pull request that modifies the build process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants