HDDS-14571. Remove synchronized methods from XceiverClientGrpc#9718
Merged
smengcl merged 8 commits intoapache:masterfrom Feb 24, 2026
Merged
Conversation
… channel termination.
…channel termination handling.
…cleaner channel termination handling." This reverts commit 7b6b0ee.
…onized modifier from close method.
…ronized methods in XceiverClientGrpc.
yandrey321
reviewed
Feb 6, 2026
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
Show resolved
Hide resolved
yandrey321
reviewed
Feb 6, 2026
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
Outdated
Show resolved
Hide resolved
yandrey321
reviewed
Feb 6, 2026
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
Outdated
Show resolved
Hide resolved
yandrey321
reviewed
Feb 6, 2026
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
Outdated
Show resolved
Hide resolved
yandrey321
reviewed
Feb 6, 2026
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
Outdated
Show resolved
Hide resolved
Contributor
|
@yandrey321 please try to avoid "Add single comment", rather "Start review" and submit all comments in a single batch via "Review changes" |
yandrey321
reviewed
Feb 6, 2026
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
Show resolved
Hide resolved
yandrey321
reviewed
Feb 6, 2026
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
Show resolved
Hide resolved
…o improve channel management and reduce synchronization.
… state management in XceiverClientGrpc.
Contributor
Author
|
Thanks for the review @yandrey321. I have updated the PR. Could you please take a look again? |
yandrey321
reviewed
Feb 10, 2026
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
Show resolved
Hide resolved
yandrey321
reviewed
Feb 10, 2026
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
Outdated
Show resolved
Hide resolved
…nel termination and improve log clarity.
Contributor
|
Thanks @ptlrs for tha patch. Thanks @yandrey321 for reviewing this. |
Contributor
ptlrs
deleted the
HDDS-14571-XceiverClientGrpcClose-remove-synchronized
branch
Contributor
Author
|
Thanks for the reviews @yandrey321 @smengcl @adoroszlai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR originates from https://issues.apache.org/jira/browse/HDDS-14454 refactors the code to use ConcurrentHashMaps and remove the synchronized methods that are used in XceiverClientGrpc
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14571
How was this patch tested?
CI: https://github.com/ptlrs/ozone/actions/runs/21737324867