HDDS-15491. [DiskBalancer] Preserve datanode order in status command output.#10450
Open
slfan1989 wants to merge 1 commit into
Open
HDDS-15491. [DiskBalancer] Preserve datanode order in status command output.#10450slfan1989 wants to merge 1 commit into
slfan1989 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR preserves the datanode order in the non-JSON output of the DiskBalancer status command.
The DiskBalancer status command executes requests in the order provided by the user, or in the order resolved by
--in-service-datanodes. However, the non-JSON status output previously collected successful responses fromConcurrentHashMap.values(), which does not guarantee iteration order.As a result, the displayed status rows could appear in a different order from the input datanode list. This PR updates the rendering path to build the status result list according to the ordered
successNodeslist instead.The PR also updates the CLI unit test to verify that status output preserves the requested datanode order.
What is the link to the Apache JIRA
HDDS-15491. [DiskBalancer] Preserve datanode order in status command output.
How was this patch tested?
Add Junit Test.
CI: https://github.com/slfan1989/ozone/actions/runs/27052253038