HDDS-14826. Prepare OM to switch from LayoutVersionManager to ComponentVersionManager#10098
Open
errose28 wants to merge 7 commits intoapache:HDDS-14496-zdufrom
Open
HDDS-14826. Prepare OM to switch from LayoutVersionManager to ComponentVersionManager#10098errose28 wants to merge 7 commits intoapache:HDDS-14496-zdufrom
errose28 wants to merge 7 commits intoapache:HDDS-14496-zdufrom
Conversation
…d small cleanups - Add ComponentVersionManager / HDDSVersionManager / OMVersionManager and related upgrade framework pieces (no OM production wiring). - Move @DisallowedUntilLayoutVersion onto preExecute for snapshot move requests; minor DN/doc/repair/freon cleanups. - Include HDDS-side renames and SCM wiring updates that accompany the version-manager refactor (no functional change on the HDDS side). - Keep LayoutVersionManager + AbstractLayoutVersionManager implementing it until OM wiring PR (HDDS matches feature except those two files). - Include OM wire-compatibility/doc/deprecation proto tweaks, OMStorage apparent-version init alignment, finalize-upgrade response naming, and a comment clarification in OzoneManagerRequestHandler (no OM prod wiring).
…ntVersion() for PR1 compile Made-with: Cursor
…Version() for PR1 compile Made-with: Cursor
…age#getLayoutVersion Made-with: Cursor
…g PR Made-with: Cursor
…ng PR Made-with: Cursor
…pgrade result codes Made-with: Cursor
sodonnel
approved these changes
Apr 22, 2026
Contributor
sodonnel
left a comment
There was a problem hiding this comment.
I think this looks OK. +1 to commit and we can rebase the next one on top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds functionality and renames to prepare OM to be switched to the new versioning framework. This PR is intended to have no impact to production code and does not do any functional migration. It:
OMVersionManagerto load upgrade actions that correspond to different versions.HDDSVersionManager.OMVersionManagercan handle unknown or invalid apparent versions on startup and fixes an issue in this area.OM version framework migration is completed in #10099. Reference that PR to see how the changes here are used.
What is the link to the Apache JIRA
HDDS-14826
How was this patch tested?
All tests pass on my fork.
New unit tests were added for new version manager functionality like detecting invalid versions at startup and executing upgrade actions. Existing tests are expected to pass since the new version manager is not yet used in prod code.