sim: Add Berry interpreter configuration#19224
Conversation
|
Hi @speccy88 please fix Doc |
089cab5 to
4c55e0c
Compare
|
@speccy88 seems like the defconfig you added is not updated (normalized) with the current nuttx-apps and/or nuttx repos: Please rebase your branch with upstream repos and then normalize your board: |
4c55e0c to
7239051
Compare
|
Updated after apache/nuttx-apps#3564 merged. I rebased this branch again onto current apache/nuttx master and reran the requested normalization with current apache/nuttx-apps master available as ../apps: ./tools/refresh.sh --silent sim:berryThe refresh completed with no tracked defconfig diff. I also verified locally: ./tools/checkpatch.sh -c -u -m -g origin/master..HEAD
git diff --check origin/master..HEAD
./tools/configure.sh -a ../apps sim:berry
make olddefconfig
make -j8The local sim:berry build completed successfully. I also smoke-tested the simulator: berry -v
berry -e print(40+2)which printed Current pushed head: bcac56e. |
Add a sim:berry configuration to exercise the Berry interpreter. Document the new berry command under applications/interpreters. Signed-off-by: Frederick Blais <fred_blais5@hotmail.com>
7239051 to
bcac56e
Compare
|
@speccy88 but the ci still hit error: |
|
@speccy88 I fetched your PR and tested locally and also got an error: Seems like your patch 0001-Fix-Berry-default-port-for-NuttX.patch doesn't apply to berry-4db341475df9e9ad18e6741ef978b4c467690e09.zip Please double check, probably you used a different commit to apply it. |
|
@speccy88 Of course, the same problem exists with CMake test Nuttx repository: speccy88/nuttx https://github.com/simbit18/manual-nuttx-ci/actions/runs/28325515810/job/83914783218 |
|
You were right; the failure was real. Root cause: Berry upstream stores I opened the companion apps fix here: apache/nuttx-apps#3567 That fix normalizes the downloaded Berry Validated locally:
Sorry for the churn on this one. The line-ending mismatch should be fixed by the apps PR. |
Summary
Documentation/applications/interpreters/berry.sim:berryconfiguration that enables the Berry interpreter and its required dependencies.Context
This is the NuttX-side companion for the optional Berry interpreter app proposed in apache/nuttx-apps#3564.
Testing
Built
sim:berryagainst apache/nuttx-apps#3564 locally on macOS arm64:Runtime smoke test: