Project priming disabling option added to lsp server#9216
Open
nozjkoitop wants to merge 1 commit intoapache:masterfrom
Open
Project priming disabling option added to lsp server#9216nozjkoitop wants to merge 1 commit intoapache:masterfrom
nozjkoitop wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make auto priming optional
java.lsp.serverautomatically attempts project priming during project open by invokingActionProvider.COMMAND_PRIMEwhen the action is available and enabled.Priming is useful by default, but currently there is no server-level switch to suppress it for environments where automatic background build activity is undesirable (resource-constrained, offline, policy-restricted, or deterministic startup scenarios)
This behavior has caused user-facing issues (f.e. oracle/javavscode#490)
This change introduces an explicit
disableProjectPrimingflag for automatic project priming in Server.primeProjects(...)Key points:
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)