[main] Reopen log file when rollover is unsuccessful (#3226 port)#4154
Open
vpelikh wants to merge 1 commit into
Open
[main] Reopen log file when rollover is unsuccessful (#3226 port)#4154vpelikh wants to merge 1 commit into
vpelikh wants to merge 1 commit into
Conversation
vpelikh
changed the title
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #3226 to the
mainbranch (3.x).Changes
RollingFileManager.java
releaseRequired→outputStreamClosed/asyncActionStartedsuccess→syncActionSuccessoutputStreamClosedinstead ofsuccess/ barefalse— when a rollover'ssynchronous action fails, the output stream has still been closed, so the log
file must be reopened
RollingFileManagerTest.java
testSynchronousActionFailure— removedinitialTimeassertions,verifies file content is preserved after failed rollover
testRolloverOfDeletedFile— verifies that rolling over a deleted filecorrectly reopens the log file
Changelog
src/changelog/.3.x.x/2592_fix_rollover_file_reopen.xmlCloses: #2592