[main] Fix RegexFilter NPE when useRawMsg is null (#3265 port)#4152
Open
vpelikh wants to merge 1 commit into
Open
[main] Fix RegexFilter NPE when useRawMsg is null (#3265 port)#4152vpelikh wants to merge 1 commit into
useRawMsg is null (#3265 port)#4152vpelikh wants to merge 1 commit into
Conversation
Avoid NPE when unboxing a null Boolean by using Boolean.TRUE.equals(). Signed-off-by: Vasily Pelikh <2010720+vpelikh@users.noreply.github.com>
vpelikh
force-pushed
the
GH-3265-port-to-main
branch
from
f0af2d0 to
666c239
Compare
vpelikh
changed the title
useRawMsg is null (#3265)useRawMsg is null (#3265 port)
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the fix from #3265 from the
2.xbranch tomain.In the
RegexFilter.createFilter()factory method, theuseRawMsgparameter is declared asBoolean(boxed). When passed directly to theRegexFilter(boolean raw, ...)constructor, anullvalue causes an NPE during unboxing.This change uses
Boolean.TRUE.equals(useRawMsg)instead, which safely handlesnullby defaulting tofalse.Changes
log4j-core/.../filter/RegexFilter.java: ChangeduseRawMsg→Boolean.TRUE.equals(useRawMsg)in constructor calllog4j-core-test/.../filter/RegexFilterTest.java: Added test ensuring no exception whenuseRawMsgisnull