Add support for max compression delay in compression actions#4071
Add support for max compression delay in compression actions#4071ramanathan1504 wants to merge 3 commits intoapache:2.xfrom
Conversation
vy
left a comment
There was a problem hiding this comment.
@ramanathan1504, thanks for taking the time. See my remarks and please add a changelog entry.
TBH, I find your submission very sloppy in the sense that it appears to be generated using an LLM prompt and then without a review from your side pushed on us for review. Please, don't do this. Review your changes before asking review from others.
ok next time i will aware about this.. i think its happened couple of time..thanks |
0ec2546 to
9a42eb7
Compare
Fixes #4012
Changes
maxCompressionDelayparameter toGzCompressActionandZipCompressActionFileExtensionto support max compression delay configurationDefaultRolloverStrategyto pass compression delay settings to compression actionsFiles Modified
Core Implementation
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/FileExtension.javalog4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/GzCompressAction.javalog4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/ZipCompressAction.javalog4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/DefaultRolloverStrategy.javaTests
log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/rolling/FileExtensionCompressDelayTest.java(new)log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/rolling/action/GzCompressActionTest.java(new)log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/rolling/action/ZipCompressActionTest.java(new)