Skip to content

Comments

Add IT for new operators introduced by window function optimization#17209

Open
Sh-Zh-7 wants to merge 3 commits intomasterfrom
test/szh/add_more_tests_for_window_func
Open

Add IT for new operators introduced by window function optimization#17209
Sh-Zh-7 wants to merge 3 commits intomasterfrom
test/szh/add_more_tests_for_window_func

Conversation

@Sh-Zh-7
Copy link
Contributor

@Sh-Zh-7 Sh-Zh-7 commented Feb 20, 2026

As per title.

This PR adds IT for RowNumberOperator, TopKRankingOperator and ValuesOperator.

This PR also finds out one bug in current TopKRankingOperator implementation. When TopK operator is not used with PARTITION BY, the result set is empty, which is not expected.

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.70%. Comparing base (7e0837b) to head (ebc7bac).

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17209      +/-   ##
============================================
+ Coverage     39.51%   39.70%   +0.19%     
  Complexity      282      282              
============================================
  Files          5101     5101              
  Lines        341895   341900       +5     
  Branches      43525    43526       +1     
============================================
+ Hits         135085   135750     +665     
+ Misses       206810   206150     -660     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant