Add IT for new operators introduced by window function optimization#17209
Open
Add IT for new operators introduced by window function optimization#17209
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17209 +/- ##
============================================
+ Coverage 39.51% 39.70% +0.19%
Complexity 282 282
============================================
Files 5101 5101
Lines 341895 341900 +5
Branches 43525 43526 +1
============================================
+ Hits 135085 135750 +665
+ Misses 206810 206150 -660 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



As per title.
This PR adds IT for RowNumberOperator, TopKRankingOperator and ValuesOperator.
This PR also finds out one bug in current TopKRankingOperator implementation. When TopK operator is not used with
PARTITION BY, the result set is empty, which is not expected.