Fix NULL predicate error in table model without TAG columns#17053
Open
Young-Leo wants to merge 1 commit intoapache:masterfrom
Open
Fix NULL predicate error in table model without TAG columns#17053Young-Leo wants to merge 1 commit intoapache:masterfrom
Young-Leo wants to merge 1 commit intoapache:masterfrom
Conversation
JackieTien97
requested changes
Jan 21, 2026
Comment on lines
+376
to
+382
| @Override | ||
| protected Filter visitCast(Cast node, Context context) { | ||
| if (node.getExpression() instanceof NullLiteral) { | ||
| return new FalseLiteralFilter(); | ||
| } | ||
| return process(node.getExpression(), context); | ||
| } |
Contributor
There was a problem hiding this comment.
not right, what if I write CAST(NULL AS BOOLEAM) IS NULL ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a table-model issue where NULL-related predicates fail only
when the table has no TAG columns, while the same predicates work when
TAG columns exist.
Repro (table model)
Table without TAG (used to fail)
Table with TAG (used to work)
Fix
Handle casted NULL predicates across predicate visitors so the no-TAG
path no longer fails.