IGNITE-28770 : Introduce a operation context attributes registry v2#13243
Open
Vladsz83 wants to merge 14 commits into
Open
IGNITE-28770 : Introduce a operation context attributes registry v2#13243Vladsz83 wants to merge 14 commits into
Vladsz83 wants to merge 14 commits into
Conversation
…-attributes-registry
…-attributes-registry
…-attributes-registry_v2
petrov-mg
reviewed
Jun 19, 2026
| private static final DistributedOperationAttributeManager INSTANCE = new DistributedOperationAttributeManager(); | ||
|
|
||
| /** Attributes by their id. */ | ||
| private final Map<Byte, OperationContextAttribute<? extends Message>> attrs = new ConcurrentHashMap<>(); |
Contributor
There was a problem hiding this comment.
We can replace it with an array and keep it sorted by ID.
Contributor
Author
There was a problem hiding this comment.
I suggest a sorted map. I don't like structures like List<T2<Byte, OperationContextAttribute<? extends Message>>>
| /** Operation context attributes message. */ | ||
| @GridToStringInclude | ||
| @Order(5) | ||
| public @Nullable DistributedOperationContextAttributesMessage opCtxMsg; |
Contributor
There was a problem hiding this comment.
I would prefer to have getters and setters just like for all other variables.
Contributor
Author
There was a problem hiding this comment.
We do not use getters and setters in the messages
| public class DistributedOperationContextAttributesMessage implements Message { | ||
| /** Values of operation context attributes. */ | ||
| @Order(0) | ||
| public List<Message> vals; |
Contributor
There was a problem hiding this comment.
I would prefer just plain array here.
Contributor
Author
There was a problem hiding this comment.
I've reverted plain array. It cannot change its size while we do not know actual number of effective context attributes. Or we have to do another re-copy of it with actual size. It looks not better to me.
petrov-mg
reviewed
Jun 19, 2026
petrov-mg
reviewed
Jun 19, 2026
| if (attrs.size() == OperationContextAttribute.MAX_ATTR_CNT) | ||
| throw new IgniteException("Maximum number of ributed attributes is exceeded [" + OperationContextAttribute.MAX_ATTR_CNT + "]."); | ||
|
|
||
| attrs.compute(id, (id0, attr0) -> { |
Contributor
There was a problem hiding this comment.
Sorry, static -> synchronized
| } | ||
|
|
||
| /** */ | ||
| public <T extends Message> OperationContextAttribute<T> createDistributedAttriubte(byte id, @Nullable T initVal) { |
petrov-mg
reviewed
Jun 19, 2026
| /** */ | ||
| public class DistributedOperationContextAttributeManager { | ||
| /** */ | ||
| static final byte MAX_DISTRIBUTED_ATTR_CNT = 7; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.