IGNITE-28374 Calcite. Fix SQL select by _key for a composite pk for key class

[zstan]

No description provided.

[Copilot]

Pull request overview

This PR updates Calcite execution so SQL predicates on _key for composite primary keys work when the key is provided as a Java key class (not already a BinaryObject), and extends test coverage around composite PK key comparisons and scan selection.

Changes:

• Add a binary marshalling hook to ExecutionContext and wire it from ExecutionServiceImpl so dynamic parameters can be converted to BinaryObject when needed.
• Adjust IndexWrappedKeyScan to gracefully handle mismatched/invalid binary key types by skipping boundary creation (matching table-scan behavior).
• Rework/extend Calcite integration tests for composite PK _key comparisons, ordering, and “unexpected key type” scenarios; plus minor nullability/spelling tweaks.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
modules/core/src/main/java/org/apache/ignite/internal/plugin/IgniteLogInfoProviderImpl.java	Minor ASCII logo correction.
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ExecutionServiceImpl.java	Creates and passes a binary marshaller into execution contexts.
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ExecutionContext.java	Accepts marshaller and uses it for parameter conversion (notably _key).
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/IndexWrappedKeyScan.java	Skips index boundary creation when _key binary type mismatches index key type.
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/IndexScan.java	Minor comment typo fix in changed hunk.
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ExchangeServiceImpl.java	Updates ExecutionContext construction for inbox context (new ctor arg).
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/CacheTableDescriptorImpl.java	Removes unnecessary checked exception from a helper.
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/util/TypeUtils.java	Adds @Nullable return annotations for internal conversions.
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/IgniteSqlFunctions.java	Adds @Nullable return annotations for toBigDecimal overloads.
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/PlanExecutionTest.java	Updates ExecutionContext construction for new ctor arg.
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/exec/RuntimeSortedIndexTest.java	Updates ExecutionContext construction for new ctor arg.
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/AbstractExecutionTest.java	Updates ExecutionContext construction for new ctor arg.
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/exec/LogicalRelImplementorTest.java	Updates ExecutionContext construction for new ctor arg (currently passes null).
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/SelectByKeyFieldTest.java	Large test refactor/expansion for composite PK _key behavior and forced scan types.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.