IGNITE-28621 SQL: Add H2 map query details to system view and logs#13091
Open
chesnokoff wants to merge 2 commits intoapache:masterfrom
Open
IGNITE-28621 SQL: Add H2 map query details to system view and logs#13091chesnokoff wants to merge 2 commits intoapache:masterfrom
chesnokoff wants to merge 2 commits intoapache:masterfrom
Conversation
849559a to
83b64fc
Compare
chesnokoff
commented
May 3, 2026
| cursor.iterator().next(); | ||
|
|
||
| for (int i = 0; i < 2; i++) { | ||
| int nodeIdx = i; |
Contributor
Author
There was a problem hiding this comment.
effective final variable
chesnokoff
commented
May 4, 2026
Comment on lines
-684
to
-726
| /** Test map query flag in running queries system view. */ | ||
| @Test | ||
| public void testMapQueryRunningQueriesView() throws Exception { | ||
| IgniteEx ignite = startGrids(2); | ||
|
|
||
| IgniteCache<Integer, String> cache = ignite.createCache( | ||
| new CacheConfiguration<Integer, String>(DEFAULT_CACHE_NAME) | ||
| .setCacheMode(CacheMode.PARTITIONED) | ||
| .setIndexedTypes(Integer.class, String.class) | ||
| ); | ||
|
|
||
| for (int i = 0; i < 10; i++) | ||
| cache.put(i, Integer.toString(i)); | ||
|
|
||
| awaitPartitionMapExchange(); | ||
|
|
||
| String initiatorId = UUID.randomUUID().toString(); | ||
|
|
||
| try (FieldsQueryCursor<List<?>> cursor = cache.query(new SqlFieldsQuery("SELECT * FROM String") | ||
| .setQueryInitiatorId(initiatorId) | ||
| .setPageSize(1))) { | ||
| cursor.iterator().next(); | ||
|
|
||
| for (int i = 0; i < 2; i++) { | ||
| int nodeIdx = i; | ||
| UUID nodeId = grid(nodeIdx).localNode().id(); | ||
|
|
||
| assertTrue(waitForCondition(() -> { | ||
| SystemView<SqlQueryView> view = grid(nodeIdx).context().systemView().view(SQL_QRY_VIEW); | ||
|
|
||
| for (SqlQueryView qry : view) { | ||
| if (qry.mapQuery() | ||
| && nodeId.equals(qry.nodeId()) | ||
| && ignite.localNode().id().equals(qry.originNodeId()) | ||
| && initiatorId.equals(qry.initiatorId())) | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| }, 5_000)); | ||
| } | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Initially, created this test to check map queries but now I think the test may be flaky so I decided to rollback it (the test passed for visa)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see tabPR Checkat TC.Bot - Instance 1 or TC.Bot - Instance 2)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.