IGNITE-28223 Provide the ability to add pseudo columns to tables for Calcite engine#12893
IGNITE-28223 Provide the ability to add pseudo columns to tables for Calcite engine#12893tkalkirill wants to merge 18 commits intomasterfrom
Conversation
| int scale(); | ||
|
|
||
| /** @return Precision of pseudocolumn type, {@value #NOT_SPECIFIED} if not specified. */ | ||
| int precision(); |
There was a problem hiding this comment.
It is inconvenient when two fields have the same constant.
There was a problem hiding this comment.
Why?
The constant is a fairly universal and understandable constant.
I asked the copilot, and he said it's OK.
There was a problem hiding this comment.
I was glad to see that you reinforce your viewpoint even if it is an electrical mind.
|
|
||
| /** */ | ||
| private void checkPseudoColumns(CreateTableCommand cmd) { | ||
| PseudoColumnProvider pseudoColProv = cacheProc.context().kernalContext().plugins().createComponentOrDefault( |
There was a problem hiding this comment.
Same default in all places where you call createcomponent. Let's bring it inside the method.
There was a problem hiding this comment.
Into which method? Please give more specifics.
There was a problem hiding this comment.
I think it might not be necessary to carry around the EMPTY constant. Is there really no way to encapsulate it in the method createComponent?
...ain/java/org/apache/ignite/internal/processors/query/calcite/exec/ddl/DdlCommandHandler.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/ignite/internal/processors/query/calcite/exec/ddl/DdlCommandHandler.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/ignite/internal/processors/query/calcite/prepare/IgniteSqlValidator.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/ignite/internal/processors/query/calcite/schema/CacheTableDescriptorImpl.java
Show resolved
Hide resolved
.../org/apache/ignite/internal/processors/query/calcite/schema/PseudoCacheColumnDescriptor.java
Show resolved
Hide resolved
.../org/apache/ignite/internal/processors/query/calcite/schema/PseudoCacheColumnDescriptor.java
Show resolved
Hide resolved
|
2 participants
https://issues.apache.org/jira/browse/IGNITE-28223