Skip to content

ci(common): run PR title check from dedicated workflow#3301

Open
Standing-Man wants to merge 1 commit into
apache:masterfrom
Standing-Man:trigger-pr-title
Open

ci(common): run PR title check from dedicated workflow#3301
Standing-Man wants to merge 1 commit into
apache:masterfrom
Standing-Man:trigger-pr-title

Conversation

@Standing-Man
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale

What changed?

Move the semantic PR title validation out of common pre-merge checks so editing a PR title can retrigger only the lightweight title CI.

Local Execution

  • Passed / not passed
    Passed
  • Pre-commit hooks ran / not ran
    Ran

AI Usage

Move the semantic PR title validation out of common pre-merge checks so
editing a PR title can retrigger only the lightweight title CI.

Signed-off-by: StandingMan <jmtangcs@gmail.com>
@github-actions
Copy link
Copy Markdown

Thanks for the pull request. It is now waiting for review, labeled S-waiting-on-review.

You can update that label as the review goes back and forth, with slash commands - each on its own line, in a regular PR comment (not an inline review reply):

  • /ready - mark it S-waiting-on-review again, after addressing feedback
  • /author - mark it S-waiting-on-author (maintainers, or anyone who has had a PR merged before)
  • /request-review @user ... - request reviewers (@user or @org/team)

Commands take up to ~90s to apply. If no reaction (👍 or 😕) appears on your comment, the apply step likely failed - check the repo's Actions tab for the PR Triage Apply run. Commands posted inside a review body (rather than a normal comment) cannot be reacted to, so they stay log-only.

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label May 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.08%. Comparing base (c3e4db7) to head (98de36b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3301      +/-   ##
============================================
- Coverage     74.13%   74.08%   -0.05%     
  Complexity      943      943              
============================================
  Files          1205     1205              
  Lines        111034   111034              
  Branches      87592    87625      +33     
============================================
- Hits          82314    82264      -50     
- Misses        25961    25975      +14     
- Partials       2759     2795      +36     
Components Coverage Δ
Rust Core 75.24% <ø> (-0.04%) ⬇️
Java SDK 58.44% <ø> (ø)
C# SDK 70.24% <ø> (-0.41%) ⬇️
Python SDK 81.43% <ø> (ø)
Node SDK 91.53% <ø> (+0.09%) ⬆️
Go SDK 39.91% <ø> (ø)
see 29 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


jobs:
pr-title:
name: Check PR Title
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving the title check out of _common.yml breaks the transitive dependency through finalize_pr. branch protection in .asf.yaml currently lists only finalize_pr as required, so this check is now advisory rather than merge-blocking. live API confirms the registered check-run name is "Check PR Title" (top-level workflows do not get the workflow / job prefix).

if keeping this as a required gate is intended, two options:

  • add contexts: - "Check PR Title" to .asf.yaml under protected_branches.master.required_status_checks.
  • rename this job to name: PR Title and add "PR Title" to contexts. workflow name and check name then align, single source of truth. cleaner.

on:
pull_request:
branches: [master]
types: [opened, edited, reopened, synchronize]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

synchronize cannot change the PR title (it fires on new commits, no changes payload). redundant for the current advisory setup. keeping it is reasonable forward-compat though - the amannn/action-semantic-pull-request README recommends synchronize for any workflow that may become a required check, since required checks must run against the head SHA.


concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cancel-in-progress: true is safe while this check is advisory. if it is later promoted to a required status check, note that cancelled does not satisfy required status - rapid edits could leave a stale cancelled check on the PR. consider cancel-in-progress: false at that point.

@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author PR is waiting on author response

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants