ci(common): run PR title check from dedicated workflow#3301
ci(common): run PR title check from dedicated workflow#3301Standing-Man wants to merge 1 commit into
Conversation
Move the semantic PR title validation out of common pre-merge checks so editing a PR title can retrigger only the lightweight title CI. Signed-off-by: StandingMan <jmtangcs@gmail.com>
|
Thanks for the pull request. It is now waiting for review, labeled You can update that label as the review goes back and forth, with slash commands - each on its own line, in a regular PR comment (not an inline review reply):
Commands take up to ~90s to apply. If no reaction (👍 or 😕) appears on your comment, the apply step likely failed - check the repo's Actions tab for the See CONTRIBUTING.md for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3301 +/- ##
============================================
- Coverage 74.13% 74.08% -0.05%
Complexity 943 943
============================================
Files 1205 1205
Lines 111034 111034
Branches 87592 87625 +33
============================================
- Hits 82314 82264 -50
- Misses 25961 25975 +14
- Partials 2759 2795 +36
🚀 New features to boost your workflow:
|
|
|
||
| jobs: | ||
| pr-title: | ||
| name: Check PR Title |
There was a problem hiding this comment.
moving the title check out of _common.yml breaks the transitive dependency through finalize_pr. branch protection in .asf.yaml currently lists only finalize_pr as required, so this check is now advisory rather than merge-blocking. live API confirms the registered check-run name is "Check PR Title" (top-level workflows do not get the workflow / job prefix).
if keeping this as a required gate is intended, two options:
- add
contexts: - "Check PR Title"to.asf.yamlunderprotected_branches.master.required_status_checks. - rename this job to
name: PR Titleand add"PR Title"to contexts. workflow name and check name then align, single source of truth. cleaner.
| on: | ||
| pull_request: | ||
| branches: [master] | ||
| types: [opened, edited, reopened, synchronize] |
There was a problem hiding this comment.
synchronize cannot change the PR title (it fires on new commits, no changes payload). redundant for the current advisory setup. keeping it is reasonable forward-compat though - the amannn/action-semantic-pull-request README recommends synchronize for any workflow that may become a required check, since required checks must run against the head SHA.
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
cancel-in-progress: true is safe while this check is advisory. if it is later promoted to a required status check, note that cancelled does not satisfy required status - rapid edits could leave a stale cancelled check on the PR. consider cancel-in-progress: false at that point.
Which issue does this PR close?
Rationale
What changed?
Move the semantic PR title validation out of common pre-merge checks so editing a PR title can retrigger only the lightweight title CI.
Local Execution
Passed
Ran
AI Usage