API, Spark 4.1: Add ignore_missing_files to migrate procedure#16643
Open
drexler-sky wants to merge 1 commit into
Open
API, Spark 4.1: Add ignore_missing_files to migrate procedure#16643drexler-sky wants to merge 1 commit into
drexler-sky wants to merge 1 commit into
Conversation
huaxingao
changed the title
huaxingao
reviewed
Jun 1, 2026
| private static final ProcedureParameter PARALLELISM_PARAM = | ||
| optionalInParameter("parallelism", DataTypes.IntegerType); | ||
| private static final ProcedureParameter IGNORE_MISSING_FILES_PARAM = | ||
| optionalInParameter("ignore_missing_files", DataTypes.BooleanType); |
Contributor
There was a problem hiding this comment.
could you document the new parameter in docs/docs/spark-procedures.md
huaxingao
reviewed
Jun 1, 2026
| } | ||
|
|
||
| @TestTemplate | ||
| public void testMigrateIgnoreMissingFiles() throws IOException { |
Contributor
There was a problem hiding this comment.
this test only exercises => true, could you add a negative test too?
ebyhr
reviewed
Jun 2, 2026
| sql("SELECT * FROM %s", tableName)); | ||
| } | ||
|
|
||
| private static void deleteDirectory(Path dir) throws IOException { |
Member
There was a problem hiding this comment.
We could use FileUtils.deleteDirectory method instead.
| * @param ignore whether to ignore missing source files | ||
| * @return this for method chaining | ||
| */ | ||
| default MigrateTable ignoreMissingFiles(boolean ignore) { |
Member
There was a problem hiding this comment.
I'm wondering if we really need boolean ignore argument here. We could remove it, and modify MigrateTableProcedure to something like:
boolean ignoreMissingFiles = input.asBoolean(IGNORE_MISSING_FILES_PARAM, false);
if (ignoreMissingFiles) {
migrateTableSparkAction = migrateTableSparkAction.ignoreMissingFiles();
}The existing drop_backup parameter employs this style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.