feat(iceberg): Enable delete files processing in snapshot producer#2367
Open
CTTY wants to merge 6 commits into
Open
feat(iceberg): Enable delete files processing in snapshot producer#2367CTTY wants to merge 6 commits into
CTTY wants to merge 6 commits into
Conversation
CTTY
commented
Apr 24, 2026
1 task
xanderbailey
reviewed
May 7, 2026
Contributor
xanderbailey
left a comment
xanderbailey
left a comment
There was a problem hiding this comment.
Nice PR! Took a pass at reviewing, let me know if it makes sense!
Comment on lines
-87
to
94
| let snapshot_producer = SnapshotProducer::new( | ||
| table, | ||
| self.commit_uuid.unwrap_or_else(Uuid::now_v7), | ||
| self.key_metadata.clone(), | ||
| self.snapshot_properties.clone(), | ||
| self.added_data_files.clone(), | ||
| ); | ||
| let snapshot_producer = SnapshotProducer::builder() | ||
| .with_table(table) | ||
| .with_commit_uuid(self.commit_uuid.unwrap_or_else(Uuid::now_v7)) | ||
| .with_key_metadata(self.key_metadata.clone()) | ||
| .with_snapshot_properties(self.snapshot_properties.clone()) | ||
| .with_added_data_files(self.added_data_files.clone()) | ||
| .build(); | ||
|
|
dannycjones
reviewed
May 26, 2026
Comment on lines
391
to
395
| async fn manifest_file<OP: SnapshotProduceOperation, MP: ManifestProcess>( | ||
| &mut self, | ||
| snapshot_produce_operation: &OP, | ||
| manifest_process: &MP, | ||
| ) -> Result<Vec<ManifestFile>> { |
Contributor
There was a problem hiding this comment.
Should we rename this trait function?
It was unclear to me what it was doing, and may be lingering with an old name from when we only had simple appends.
Ultimately, it is building a list of manifest files that will be part of the new snapshot / manifest list. Perhaps build_manifest_file_list?
Collaborator
Author
There was a problem hiding this comment.
I think this makes sense, but maybe we should tackle this in a separate PR
Comment on lines
+597
to
+598
| #[cfg(test)] | ||
| mod tests { |
Contributor
There was a problem hiding this comment.
Would it be useful to have a follow-up to provide simple coverage of other manifest changes? i.e. added data files.
I'm happy to own this.
Collaborator
Author
There was a problem hiding this comment.
I think added data files are tested via integration tests. But I'm not opposed to adding more unit tests :D
CTTY
force-pushed
the
ctty/rewrite-process-delete
branch
from
a82836d to
d1ef3c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?
Added uts in snapshot.rs, we should add end-to-end tests when actual rewrite/delete actions are supported