Skip to content

fix: SaslServer busy-loop causes process hang after test suite #3305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinjqliu wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −3
Open

fix: SaslServer busy-loop causes process hang after test suite #3305

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dab3da
fix 3.13 hang during test
kevinjqliu May 1, 2026
b56fb1d
add try/catch
kevinjqliu May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/catalog/test_hive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,21 +226,24 @@ def run(self) -> None:
client.write(self._response)
client.flush()
except Exception:
pass
break

@property
def port(self) -> int | None:
self._port_bound.wait()
return self._port

def close(self) -> None:
# Close all client connections first
try:
self._socket.close()
except Exception:
pass
self.join(timeout=5)
Copy link
Copy Markdown
Contributor

@rambleraptor rambleraptor May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the feeling I know the answer, but why 5?

Copy link
Copy Markdown
Contributor Author

@kevinjqliu kevinjqliu May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just randomly picked a value, 5 seconds should be long enough for the threads to shutdown

for client in self._clients:
try:
client.close()
except Exception:
pass
self._socket.close()


@pytest.fixture(scope="session")
Expand Down
Loading