Support python 3.14#3299
Conversation
|
Could you also test the Manual trigger with these parameters: and include the link in the PR This will help test the changes in |
|
i think we can use this And remove WDYT? |
|
@kevinjqliu That looks the same as what I had originally attempted in this commit, which failed on integration test due to not picking up the env variable, set at that point in the flow. |
|
Thanks for working on this @afeldman1. I think in general this looks good, but I think it would be good to document |
hm do you remember what the error was? this worked for me when i tested it locally EDIT: nevermind, i didnt remove the env var declaration in Makefile |
|
ok i tried this solution, we can override it using pytest hook.
tested that it works with |
|
@Fokko Where were you thinking the documentation should go? |
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding this.
could you retrigger https://github.com/afeldman1/iceberg-python/actions/workflows/python-release.yml for a final check
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Rationale for this change
Adds prebuilt support for python 3.14
Free-threaded is still not supported for now
Closes #3123 for standard python
Are these changes tested?
test using:
PYTHON=3.14 make testPYTHON=3.14 make test-integrationPython Build Release Candidate workflow was run: https://github.com/afeldman1/iceberg-python/actions/runs/25225067214
Are there any user-facing changes?
Just support of python 3.14