-
Notifications
You must be signed in to change notification settings - Fork 444
feat: Add ArrivalOrder to ArrowScan for bounded-memory concurrent reads #3046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sumedhsakdeo
wants to merge
30
commits into
apache:main
Choose a base branch
from
sumedhsakdeo:fix/arrow-scan-benchmark-3036
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
5ab0fd1
feat: forward batch_size parameter to PyArrow Scanner
sumedhsakdeo c1ece14
style: fix ruff formatting in residual_evaluator lambda
sumedhsakdeo 70af67f
chore: remove unintended vendor directory changes
sumedhsakdeo 2474b12
feat: add ScanOrder enum to ArrowScan.to_record_batches
sumedhsakdeo 48b332a
feat: add concurrent_files flag for bounded concurrent streaming
sumedhsakdeo b360ae8
fix: remove unused imports in test_bounded_concurrent_batches
sumedhsakdeo 4186713
refactor: simplify _bounded_concurrent_batches with per-scan executor
sumedhsakdeo 7c415d4
refactor: replace streaming param with order=ScanOrder in concurrent …
sumedhsakdeo 70d5a99
feat: add read throughput micro-benchmark for ArrowScan configurations
sumedhsakdeo 2e044ea
fix: remove extraneous f-string prefix in benchmark
sumedhsakdeo 8dcd240
fix: properly reset mock call_count in test_hive_wait_for_lock
sumedhsakdeo 4a0a430
feat: add default-4threads benchmark and time-to-first-record metric
sumedhsakdeo 2efdcba
chore: remove default-4threads benchmark configuration
sumedhsakdeo 09aad7a
docs: add configuration guidance table to streaming API docs
sumedhsakdeo b2ae725
chore: remove benchmark marker so tests run in CI
sumedhsakdeo afb244c
refactor: replace streaming param with order=ScanOrder in benchmarks …
sumedhsakdeo 03bda3d
refactor: Replace ScanOrder enum with class hierarchy
sumedhsakdeo 19841dc
test: Update tests for new ScanOrder class hierarchy
sumedhsakdeo e06c01a
test: Refactor benchmark tests for new ScanOrder API
sumedhsakdeo c38bc76
docs: Update API documentation for ScanOrder refactoring
sumedhsakdeo 2d4a67a
Fix ScanOrder class and remove unused import
sumedhsakdeo de9f3c2
Fix long line and B008 error in ArrowScan
sumedhsakdeo ac8add8
Fix mypy errors: change concurrent_files to concurrent_streams
sumedhsakdeo b5cfb78
Fix import ordering in test files
sumedhsakdeo d93526e
Move batch_size parameter to ArrivalOrder for better semantic design
sumedhsakdeo 432cd81
Update tests for new ArrivalOrder batch_size API
sumedhsakdeo 84adcfa
Update API documentation for new ArrivalOrder batch_size parameter
sumedhsakdeo 1c73ea4
Fix to_record_batches default order and add TaskOrder import
sumedhsakdeo caa079e
Fix ruff B008: use module-level singleton for default ScanOrder
sumedhsakdeo a882dd2
fix: drain until sentinel to prevent deadlock on early generator close
sumedhsakdeo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.