fix: Hive catalog test failure on CPython 3.13.12#3043
Open
geruh wants to merge 1 commit intoapache:mainfrom
Open
fix: Hive catalog test failure on CPython 3.13.12#3043geruh wants to merge 1 commit intoapache:mainfrom
geruh wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
While reviewing some open PRs #3041, #3042, I noticed CI kept failing on the Python 3.13 job in the hive tests. Turns out CPython 3.13.12 was just released and included a change python/cpython#142651 which made
Mock.call_countthread-safe by deriving it fromlen(call_args_list).This broke our hive test, which was resetting the counter with
mock.call_count = 0directly. This switches to use reset_mock(), which properly clears all the internal call tracking state.Are these changes tested?
make testpassesAre there any user-facing changes?
no