feat: support storage-credentials in loadTable response #3033
+111
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the Iceberg REST spec, the loadTable response can include a storage-credentials field with prefix-scoped temporary credentials. Clients must check storage-credentials before falling back to the config dict. This adds longest-prefix matching for credential selection. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
storage-credentialsfield support to theloadTableREST response, per the Iceberg REST specconfigdict when nostorage-credentialsare present or no prefix matchesStraight copy of #2600 in case that is abandoned PR
Test plan
test_storage_credentials_over_config— credentials with matching prefix override configtest_config_when_no_storage_credentials— falls back to config when no storage-credentials presenttest_storage_credentials_no_prefix_match— falls back to config when prefix doesn't matchtest_storage_credentials_longest_prefix_wins— longest matching prefix is selected🤖 Generated with Claude Code