Relax REST client /v1/config response constraints#2148
Conversation
|
Thanks @ccancellieri for raising this PR. This is something that ideally should be fixed on the BigLake side, but there is no harm to be a bit more relaxed about deserializing these messages. Thoughts @kevinjqliu ? |
+1 BigLake REST catalog API should be fixed in order to be compliant with the Iceberg REST Catalog spec, which requires both That said, we've seen this issue with Nessie IRC as well (see #1524). As an IRC client, pyiceberg can be more relaxed about these fields. |
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
pyiceberg/catalog/rest/__init__.py
Outdated
|
|
||
| class ListNamespaceResponse(IcebergBaseModel): | ||
| namespaces: List[Identifier] = Field() | ||
| namespaces: Optional[List[Identifier]] = Field(default_factory=list) |
There was a problem hiding this comment.
this ones odd, i think we should revert this change. The listNamespace response should return an empty namespaces list
|
cc @rambleraptor @talatuyarer, what do you think? |
kevinjqliu
changed the title
/v1/config response constraints
This PR can be used as an interim solution, but other clients will probably error out , so eventually this has to be fixed in BigLake :) |
|
Thanks @ccancellieri for the PR and @Fokko for the review :) |
fixing apache#2122 <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change # Are these changes tested? Yes tested locally # Are there any user-facing changes? Nope, just use them --------- Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com> Co-authored-by: Fokko Driesprong <fokko@apache.org>
fixing apache#2122 <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change # Are these changes tested? Yes tested locally # Are there any user-facing changes? Nope, just use them --------- Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com> Co-authored-by: Fokko Driesprong <fokko@apache.org>
3 participants
fixing #2122
Rationale for this change
Are these changes tested?
Yes tested locally
Are there any user-facing changes?
Nope, just use them