You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This example class is derived from a reproducer I wrote to investigate several reports I've received of a latency regression in the async client, which seems to be caused by increased TLS connection establishment. I've found scads of issues in just a few hours of messing with this thing, so I think it belongs in the repo.
@arturobernalg I have to hand it to you: of the three connection pool implementations, OFFLOCK is easily the best-behaved in the scenario this example class simulates. I found major defects in both LAX and STRICT:
The other major issue is that RequestConfig#getConnectionKeepAlive (or technically, whatever the ConnectionKeepAliveStrategy returns) appears to be the only config value that is threaded into PoolEntry or the connection pool. If instead you set a TTL or idle timeout on ConnectionConfig, it never propagates into those classes, which means they lease out expired connections without even realizing it, and then the connection manager has to deal with it (by establishing a new connection). It's possible that this is actually a regression introduced in a02455a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This example class is derived from a reproducer I wrote to investigate several reports I've received of a latency regression in the async client, which seems to be caused by increased TLS connection establishment. I've found scads of issues in just a few hours of messing with this thing, so I think it belongs in the repo.