HBASE-30222 Avoid re-parsing HBase configuration on every CipherProvider construction#8354
Open
haridsv wants to merge 1 commit into
Open
HBASE-30222 Avoid re-parsing HBase configuration on every CipherProvider construction#8354haridsv wants to merge 1 commit into
haridsv wants to merge 1 commit into
Conversation
…der construction DefaultCipherProvider and CryptoCipherProvider initialized their conf field inline with HBaseConfiguration.create(), parsing hbase-default.xml and hbase-site.xml on every construction. The value was immediately discarded: Encryption.getCipherProvider() builds the provider via ReflectionUtils.newInstance(), which runs the no-arg constructor and then calls setConf(), overwriting the field. The eager parse was pure waste. Drop the inline initializer so conf is set only via setConf(), and add a fail-fast Preconditions guard in getConf() so a caller that forgets setConf() fails loudly instead of NPE-ing deep inside cipher construction. Mark the test-only getInstance() accessor as LimitedPrivate(UNITTEST). Add guard tests covering both providers. Generated-by: Claude Code (Opus 4.8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultCipherProvider and CryptoCipherProvider initialized their conf field inline with HBaseConfiguration.create(), parsing hbase-default.xml and hbase-site.xml on every construction. The value was immediately discarded: Encryption.getCipherProvider() builds the provider via ReflectionUtils.newInstance(), which runs the no-arg constructor and then calls setConf(), overwriting the field. The eager parse was pure waste.
Drop the inline initializer so conf is set only via setConf(), and add a fail-fast Preconditions guard in getConf() so a caller that forgets setConf() fails loudly instead of NPE-ing deep inside cipher construction. Mark the test-only getInstance() accessor as LimitedPrivate(UNITTEST). Add guard tests covering both providers.
Generated-by: Claude Code (Opus 4.8)