HBASE-30051 Avoid Unnecessary Protobuf Conversions in HMaster Admin API Calls#8018
Open
srinireddy2020 wants to merge 1 commit intoapache:masterfrom
Open
HBASE-30051 Avoid Unnecessary Protobuf Conversions in HMaster Admin API Calls#8018srinireddy2020 wants to merge 1 commit intoapache:masterfrom
srinireddy2020 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Do you have any performance numbers about the overhead? |
Contributor
Author
Verified performance test in HBase Mini cluster with 350 tables. Observed 97.5% improvement for this changes. Method: admin.listTableDescriptors(true)
|
Contributor
|
I mean the performance change in real workload. I see that you have changed two places, what is the performance numbers for these two places before and after this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Admin APIs invoked on the HMaster are routed internally back to the same HMaster instance, leading to unnecessary protobuf serialization and deserialization. This adds significant overhead, especially in environments with a large number of tables.