Skip to content

HBASE-29809 Unify region reopening methods to use throttled implement…#7818

Open
liuxiaocs7 wants to merge 4 commits into
apache:masterfrom
liuxiaocs7:HBASE-29809
Open

HBASE-29809 Unify region reopening methods to use throttled implement…#7818
liuxiaocs7 wants to merge 4 commits into
apache:masterfrom
liuxiaocs7:HBASE-29809

Conversation

@liuxiaocs7

Copy link
Copy Markdown
Member

…ation

@liuxiaocs7

Copy link
Copy Markdown
Member Author

Hi, @ajkh88 and @charlesconnell, could you help take a look when free, thanks!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates region-reopen call sites to consistently use the throttled reopening implementation (HBASE-29809), so region reopening honors configured throttling.

Changes:

  • Switch RegionsRecoveryChore to call HMaster.reopenRegionsThrottled instead of the unthrottled reopen method.
  • Update TestRegionsRecoveryChore expectations to verify throttled reopen calls.
  • Deprecate HMaster.reopenRegions(...) in favor of reopenRegionsThrottled(...) and fix minor logging constant/message typos in the chore.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionsRecoveryChore.java Updates Mockito verifications to assert throttled region reopen calls.
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java Adds HMaster import to support Javadoc references to throttled reopen entrypoint.
hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionsRecoveryChore.java Uses throttled reopen method and fixes typo in error constant/log message.
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java Marks the unthrottled reopen helper as deprecated and points callers to throttled variant.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liuxiaocs7 liuxiaocs7 requested a review from Apache9 April 25, 2026 14:02
import org.apache.hadoop.hbase.UnknownRegionException;
import org.apache.hadoop.hbase.client.TableDescriptor;
import org.apache.hadoop.hbase.conf.ConfigKey;
import org.apache.hadoop.hbase.master.HMaster;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why adding this import?

@liuxiaocs7 liuxiaocs7 Jun 15, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, Let me check!

Thanks

@liuxiaocs7 liuxiaocs7 Jun 15, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see, there is a java doc warning, let me remove this time.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants