HBASE-29895 BackupBoundaries global coverage can allow premature WAL deletion when backup roots have different host coverage #7746
+62
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n backup roots have different host coverage
hgromer
changed the title
ndimiduk
approved these changes
Feb 13, 2026
| // most recent backup). A WAL file can only be deleted if it's older than the boundary for ALL | ||
| // backup roots, protecting WALs needed by any backup root even when other roots have already | ||
| // backed up that host at a later timestamp. | ||
| private final Map<String, Map<Address, Long>> boundaries; |
Member
There was a problem hiding this comment.
It would be nice if BackupID had its own type. That's probably a larger change.
Member
|
FYI, I think you wanted to request reviews, not assign. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.