HBASE-29887 Upgrade hbase-hbtop to use junit5 #7734
+101
−218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
liuxiaocs7
commented
Feb 11, 2026
liuxiaocs7
commented
- see: HBASE-29887
liuxiaocs7
commented
Feb 11, 2026
| @BeforeEach | ||
| public void setup() throws IOException { | ||
| when(admin.getClusterMetrics()).thenReturn(TestUtils.createDummyClusterMetrics()); | ||
| lenient().when(admin.getClusterMetrics()).thenReturn(TestUtils.createDummyClusterMetrics()); |
Contributor
Author
There was a problem hiding this comment.
JUnit 5 performs stricter checks here.
liuxiaocs7
commented
Feb 11, 2026
| <dependency> | ||
| <groupId>org.mockito</groupId> | ||
| <artifactId>mockito-core</artifactId> | ||
| <artifactId>mockito-junit-jupiter</artifactId> |
Contributor
Author
There was a problem hiding this comment.
We need to change this mockito dependency during the migration. cc @Apache9
PDavid
approved these changes
Feb 11, 2026
Contributor
PDavid
left a comment
PDavid
left a comment
There was a problem hiding this comment.
Thanks, looks good to me. 👍
Contributor
|
Can you please raise a backport PR to |
Apache9
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.