HBASE-28601 Enable setting memstore on-heap sizes in bytes

[liuxiaocs7]

• see: HBASE-28601

[ndimiduk]

LGTM!

[ndimiduk]

Can we support human-friendly values here?

[liuxiaocs7]

Hi, @ndimiduk, sure, we support human-friendly values, just like in blockcache, and I add some more test cases in jira, please help take a look when free, thanks!!!

[liuxiaocs7]

Hi, @ndimiduk, in the runner summary(https://github.com/apache/hbase/actions/runs/21860359593?pr=7726), how can we see which ut failed, thanks!

[ndimiduk]

The failed units test should be mentioned in a table in the Summary of the run. It's kinda hard to find on the GitHub UI, and it appears to not render at all on mobile.

I'll get you a direct link when I'm back at my desk.

[ndimiduk]

It's this feature. https://github.blog/news-insights/product-news/supercharging-github-actions-with-job-summaries/

[ndimiduk]

I thought I had added this feature along with the unit test job, but I don't see the failed tests in the summary. For now, you'll have to download the artifact from that medium test run and look for the surefire reports there. Let me see what happened to that feature in our build.

[ndimiduk]

I see. I'm parsing Failures but not Errors -- i.e., unit test assertions that failed, but not uncaught thrown exceptions and the like. That's an omission.

[liuxiaocs7]

I see. I'm parsing Failures but not Errors -- i.e., unit test assertions that failed, but not uncaught thrown exceptions and the like. That's an omission.

Hi, @ndimiduk, thank you very much for your quick response. I'm relieved we've identified the underlying issue, which explains why I could sometimes see failed UTs in the Summary and sometimes not. In any case, thank you for your efforts!!!

[liuxiaocs7]

For example, in this runner job summary(https://github.com/apache/hbase/actions/runs/21894809023), we can see Failed Tests in large-wave-3 summary, but nothing in failed large-wave-1 summary.

[ndimiduk]

https://issues.apache.org/jira/browse/HBASE-29888
#7735

[ndimiduk]

The summary I'm talking about is accessed from up here

[liuxiaocs7]

https://issues.apache.org/jira/browse/HBASE-29888

@ndimiduk Got it, thanks Nick!

[liuxiaocs7]

Hi, @ndimiduk, thanks for help to retrigger the ut, medium test fails seems hbase-balancer upgrade to junit5

the first three uts below fails on my local env, maybe they need to upgrade to junit5 because they extends StochasticBalancerTestBase which located in hbase-balancer module

java.lang.NullPointerException: Cannot invoke "org.apache.hadoop.conf.Configuration.setBoolean(String, boolean)" because "org.apache.hadoop.hbase.master.balancer.TestBalancerDecision.conf" is null

	at org.apache.hadoop.hbase.master.balancer.TestBalancerDecision.testBalancerDecisions(TestBalancerDecision.java:60)

Module	Failed Tests
hbase-server	org.apache.hadoop.hbase.master.balancer.TestBalancerDecision.testBalancerDecisions
hbase-server	org.apache.hadoop.hbase.master.balancer.TestBalancerRejection.testBalancerRejections
hbase-server	org.apache.hadoop.hbase.master.balancer.TestCacheAwareLoadBalancerCostFunctions.null
hbase-server	org.apache.hadoop.hbase.replication.regionserver.TestReplicationSource.testAbortTrueOnError

[liuxiaocs7]

Let's see #7744

[liuxiaocs7]

Let's see #7744

With #7744, medium test could pass(https://github.com/apache/hbase/actions/runs/21958775498?pr=7744)!

[liuxiaocs7]

Hi, @ndimiduk, I have rebased master and re trigger ci, failed tests seems unrelated, could you help rerun the failed jobs when free, thanks!