HBASE-29874 Removing the useless parameters from ScanQueryMatcher.isC…#7720
Open
liuxiaocs7 wants to merge 2 commits intoapache:masterfrom
Open
HBASE-29874 Removing the useless parameters from ScanQueryMatcher.isC…#7720liuxiaocs7 wants to merge 2 commits intoapache:masterfrom
liuxiaocs7 wants to merge 2 commits intoapache:masterfrom
Conversation
Apache9
reviewed
Feb 9, 2026
| } | ||
| // check if the cell is expired by cell TTL | ||
| if (isCellTTLExpired(cell, this.oldestUnexpiredTS, this.now)) { | ||
| if (isCellTTLExpired(cell, this.now)) { |
Contributor
Author
There was a problem hiding this comment.
Hi, @Apache9, it appears that oldestTimestamp is not being used in isCellTTLExpired and it's confusing, so we can remove this parameter?
liuxiaocs7
force-pushed
the
HBASE-29874
branch
7 times, most recently
from
157a9a7 to
b5eebb4
Compare
liuxiaocs7
force-pushed
the
HBASE-29874
branch
from
b5eebb4 to
e18d8ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ellTTLExpired
see: HBASE-29874