[server] Fix tableCount metric after dropping partitioned tables#3482
Open
swuferhong wants to merge 2 commits into
Open
[server] Fix tableCount metric after dropping partitioned tables#3482swuferhong wants to merge 2 commits into
swuferhong wants to merge 2 commits into
Conversation
79db2d2 to
aa09e46
Compare
aa09e46 to
9214516
Compare
wuchong
reviewed
Jun 13, 2026
Comment on lines
+131
to
+134
| for (Long tableId : context.allTables().keySet()) { | ||
| if (!tablesToBeDeleted.contains(tableId)) { | ||
| tableCount++; | ||
| } |
Member
There was a problem hiding this comment.
We should reverse the lookup by iterating over tablesToBeDeleted and checking for existence in context.allTables(). If a match is found, decrement tableSize. This approach significantly improves performance.
Set<Long> allTables = context.allTables().keySet();
int tableCount = allTables.size();
for (Long toDelete : context.getTablesToBeDeleted()) {
if (allTables.contains(toDelete)) {
tableCount--;
}
}
wuchong
approved these changes
Jun 13, 2026
wuchong
left a comment
Member
There was a problem hiding this comment.
I pushed a commit to fix this comment. Please take another look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3481
processDropTable's
onDeleteTable()is a no-op for partitioned tables(their buckets live under partitionAssignments, not tableAssignments)
and they have no table-level replicas, so areAllReplicasInState is
vacuously true the moment the table enters tablesToBeDeleted. Without
an explicit trigger, resumeDeletions() runs only when some unrelated
stop-replica response piggy-backs it -- which can be never if no other
drop is in flight. The dropped table then lingers in tablesToBeDeleted
and tablePathById, inflating the tableCount gauge until something
else gets dropped.
Brief change log
Tests
API and Format
Documentation