[test] Fixing flaky test CoordinatorEventManagerTest.testMetricsUpdatedImmediatelyOnStartup#3210
Open
vamossagar12 wants to merge 1 commit intoapache:mainfrom
Open
[test] Fixing flaky test CoordinatorEventManagerTest.testMetricsUpdatedImmediatelyOnStartup#3210vamossagar12 wants to merge 1 commit intoapache:mainfrom
vamossagar12 wants to merge 1 commit intoapache:mainfrom
Conversation
…UpdatedImmediatelyOnStartup
Contributor
Author
|
@swuferhong , @wuchong please take a look at this CL which fixes the flaky test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3188
Brief change log
Fixes unstable test CoordinatorEventManagerTest.testMetricsUpdatedImmediatelyOnStartup by adding a retry to handle the brief window between metricsUpdateCount increment (inside the event processor) and the volatile field assignment (after
getResultFuture().get() in updateMetricsViaAccessContext).
I ran the tests 5 times once and 10 times the other time and the test passed on all 15 occasions.
Tests
N/A