[client] Allow bootstrap endpoint with unknown server type#622
Open
fxbing wants to merge 1 commit into
Open
Conversation
leekeiabstraction
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your first contribution and improving the client! Left a question.
| ) | ||
| .is_ok() | ||
| ); | ||
| assert!( |
Contributor
There was a problem hiding this comment.
Should a simple integration test case be made in existing IT testing with unknown type/bootstrapping against tablet server?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #621
Allow the Rust client to bootstrap from either coordinator or tablet server endpoints after server type validation is enabled.
Brief change log
ServerType::Unknownfor bootstrap seed nodes.ServerType::Unknownwhen creating the initial bootstrapServerNode.Unknown.Tests
cargo fmt --all -- --checkPROTOC=/opt/homebrew/bin/protoc cargo test -p fluss-rs --lib server_type_validationPROTOC=/opt/homebrew/bin/protoc cargo test -p fluss-rs --libPROTOC=/opt/homebrew/bin/protoc cargo clippy --all-targets --workspace -- -D warningsAPI and Format
This adds a public
ServerType::Unknownenum variant. It does not change the wire protocol or storage format.Documentation
No user-facing documentation change.