Added Default Implementations for Missing Types#326
Open
niknegi wants to merge 1 commit intoapache:mainfrom
Open
Added Default Implementations for Missing Types#326niknegi wants to merge 1 commit intoapache:mainfrom
niknegi wants to merge 1 commit intoapache:mainfrom
Conversation
luoyuxia
reviewed
Feb 15, 2026
| } | ||
| } | ||
|
|
||
| impl Default for ArrayType { |
Contributor
There was a problem hiding this comment.
we shouldn't have default for array type
| } | ||
|
|
||
| impl Default for MapType { | ||
| fn default() -> Self { |
Contributor
There was a problem hiding this comment.
we shouldn't have default for array type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #325
Brief change log
Added Default implementation for CharType, DecimalType, BinaryType, ArrayType and MapType
Tests