[FLINK-39897][table] Fix SQL serialization when using limit without order#28367
Open
autophagy wants to merge 1 commit into
Open
[FLINK-39897][table] Fix SQL serialization when using limit without order#28367autophagy wants to merge 1 commit into
autophagy wants to merge 1 commit into
Conversation
Collaborator
raminqaf
approved these changes
Jun 10, 2026
raminqaf
left a comment
raminqaf
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for fixing this! Left a nit comment.
Comment on lines
+104
to
+112
| order.stream() | ||
| .map( | ||
| expr -> | ||
| OperationExpressionsUtils.scopeReferencesWithAlias( | ||
| INPUT_ALIAS, expr)) | ||
| .map( | ||
| resolvedExpression -> | ||
| resolvedExpression.asSerializableString(sqlFactory)) | ||
| .collect(Collectors.joining(", "))); |
Contributor
There was a problem hiding this comment.
Nit: what do you think extracting this logic into a method?
Contributor
Author
There was a problem hiding this comment.
Oh, thats a nice idea 🙂 Will do
github-actions
Bot
added
the
community-reviewed
gustavodemorais
approved these changes
Jun 10, 2026
gustavodemorais
left a comment
gustavodemorais
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for fixing this, @autophagy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Currently, if you use a limit without an order, like
env.fromValues("Hello world!").limit(1)and try to produce the SQL equivalent via.getQueryOperation().asSerializableString(), you get an invalid SQL string that contains anORDER BYclause with no column/s.This PR fixes the SQL serialization of
SortQueryOperationin cases where no order is given.Brief change log
SortQueryOperationin cases where no order is given.Verifying this change
This change added tests and can be verified as follows:
QueryOperationTestPrograms.javafor alimit()without anorderBy().Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation