Skip to content

FINERACT-2421: Optimize github actions workflow#5799

Merged
adamsaghy merged 1 commit intoapache:developfrom
adamsaghy:FINERACT-2421/optimize-github-actions-workflow
Apr 26, 2026
Merged

FINERACT-2421: Optimize github actions workflow#5799
adamsaghy merged 1 commit intoapache:developfrom
adamsaghy:FINERACT-2421/optimize-github-actions-workflow

Conversation

@adamsaghy
Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy adamsaghy force-pushed the FINERACT-2421/optimize-github-actions-workflow branch from 201d575 to 2d12d94 Compare April 23, 2026 15:21
Comment thread .github/workflows/build-mariadb.yml Outdated
Comment thread .github/workflows/build-mysql.yml Outdated
Comment thread .github/workflows/build-progressive-loan.yml
@adamsaghy adamsaghy force-pushed the FINERACT-2421/optimize-github-actions-workflow branch 4 times, most recently from a2c1dca to 416b469 Compare April 23, 2026 17:36
@Aman-Mittal
Copy link
Copy Markdown
Member

Aman-Mittal commented Apr 24, 2026 via email

@adamsaghy adamsaghy force-pushed the FINERACT-2421/optimize-github-actions-workflow branch 3 times, most recently from 3c4a544 to ff11734 Compare April 24, 2026 16:31
Comment thread .github/workflows/build-e2e-tests.yml Outdated
@adamsaghy adamsaghy force-pushed the FINERACT-2421/optimize-github-actions-workflow branch from ff11734 to 80db9eb Compare April 25, 2026 00:48
Copy link
Copy Markdown
Contributor Author

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Aman-Mittal
Copy link
Copy Markdown
Member

@adamsaghy

All failed runs seems to giving cache miss error
enableCrossOsArchive: false
lookup-only: false
env:
DEVELOCITY_ACCESS_KEY:
IMAGE_NAME: fineract
BASE_URL: https://localhost:8443
TEST_USERNAME: mifos
TEST_PASSWORD: password
TEST_STRONG_PASSWORD: A1b2c3d4e5f$
TEST_TENANT_ID: default
INITIALIZATION_ENABLED: true
EVENT_VERIFICATION_ENABLED: true
ACTIVEMQ_BROKER_URL: tcp://localhost:61616
ACTIVEMQ_TOPIC_NAME: events
JAVA_HOME: /opt/hostedtoolcache/Java_Zulu_jdk/21.0.11-10/x64
JAVA_HOME_21_X64: /opt/hostedtoolcache/Java_Zulu_jdk/21.0.11-10/x64
Error: Failed to restore cache entry. Exiting as fail-on-cache-miss is set. Input key: fineract-compiled-Linux-24918448689-3

@adamsaghy adamsaghy closed this Apr 25, 2026
@adamsaghy adamsaghy reopened this Apr 25, 2026
Comment thread .github/workflows/build-e2e-tests.yml Outdated
@Aman-Mittal
Copy link
Copy Markdown
Member

@adamsaghy It seems The caches generated by your CI generating is ranging from 400MB to 900MB each which will likely overload cache of this repo at scale.

@adamsaghy adamsaghy force-pushed the FINERACT-2421/optimize-github-actions-workflow branch 2 times, most recently from c216608 to 96199c9 Compare April 25, 2026 21:12
@adamsaghy adamsaghy force-pushed the FINERACT-2421/optimize-github-actions-workflow branch from 96199c9 to e1644a3 Compare April 25, 2026 21:52
@adamsaghy
Copy link
Copy Markdown
Contributor Author

@adamsaghy

All failed runs seems to giving cache miss error enableCrossOsArchive: false lookup-only: false env: DEVELOCITY_ACCESS_KEY: IMAGE_NAME: fineract BASE_URL: https://localhost:8443 TEST_USERNAME: mifos TEST_PASSWORD: password TEST_STRONG_PASSWORD: A1b2c3d4e5f$ TEST_TENANT_ID: default INITIALIZATION_ENABLED: true EVENT_VERIFICATION_ENABLED: true ACTIVEMQ_BROKER_URL: tcp://localhost:61616 ACTIVEMQ_TOPIC_NAME: events JAVA_HOME: /opt/hostedtoolcache/Java_Zulu_jdk/21.0.11-10/x64 JAVA_HOME_21_X64: /opt/hostedtoolcache/Java_Zulu_jdk/21.0.11-10/x64 Error: Failed to restore cache entry. Exiting as fail-on-cache-miss is set. Input key: fineract-compiled-Linux-24918448689-3

Reworked and fixed. Thank you!

Copy link
Copy Markdown
Member

@Aman-Mittal Aman-Mittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems Ok now.

@Aman-Mittal
Copy link
Copy Markdown
Member

@adamsaghy Seems ok now. I have also rebased the PRs properly. When those Prs give similar results feel free to resolve my comments and merge

@adamsaghy
Copy link
Copy Markdown
Contributor Author

@adamsaghy Seems ok now. I have also rebased the PRs properly. When those Prs give similar results feel free to resolve my comments and merge

What is the expected outcome?

@Aman-Mittal
Copy link
Copy Markdown
Member

@adamsaghy Seems ok now. I have also rebased the PRs properly. When those Prs give similar results feel free to resolve my comments and merge

What is the expected outcome?
Ideally, it should happen like this, test case PR must fail or pass similarly to their original PRs,

I have raised 2 prs that must pass and 2 that must fail.
(If they are failing due to flaky test case try rerunning those again).

@Aman-Mittal
Copy link
Copy Markdown
Member

@adamsaghy rerun the flaky test case in adamsaghy#4
All other PRs is working as expected. And this is also working as expected but seems to failing not because of your code. Needs more digging.
But i definitely say your PR is ready for merge now.

@adamsaghy adamsaghy merged commit 5dda254 into apache:develop Apr 26, 2026
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants