Draft
Conversation
Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com>
…ILIKE Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com>
…arch-api Add case-insensitive search and productId to Search API
Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com>
…-productid Add productId filter to loans list endpoint
…tedDate Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com>
…uery-issue Fix ClassCastException in trial balance job query
Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com>
Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com>
…upport Add journal entry support to Batch API
Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com> Agent-Logs-Url: https://github.com/andrew-nkhoma/fineract/sessions/b9263c3c-b857-4b66-befa-eacc255e4902
…-for-teller-issues Add Teller Cash Management redesign issue tracking: docs + creation script
Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com> Agent-Logs-Url: https://github.com/andrew-nkhoma/fineract/sessions/1d41532b-22ef-4b60-ba1b-b904516b3144
Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com> Agent-Logs-Url: https://github.com/andrew-nkhoma/fineract/sessions/319dd767-de4e-4d79-8ee4-3cb031c70cab
…ebit-credit-accounts Fix #17: PUT /tellers silently drops debitAccountId and creditAccountId
…raint-cashiers Fix: Remove m_cashiers unique constraint on (staff_id, teller_id)
…ints Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com> Agent-Logs-Url: https://github.com/andrew-nkhoma/fineract/sessions/c6880b26-04d8-4598-bfd0-3d93dca59ca3
…ansaction params Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com> Agent-Logs-Url: https://github.com/andrew-nkhoma/fineract/sessions/c6880b26-04d8-4598-bfd0-3d93dca59ca3
…-parameters Fix: fromDate/toDate query parameters ignored on cashier transactions endpoints
Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com> Agent-Logs-Url: https://github.com/andrew-nkhoma/fineract/sessions/9ce2e2d0-d771-4373-9bb5-72bbb52de1da
…ons-table feat: Add m_cashier_sessions table and JPA entity (Issue #20)
…-out) in closeSession() and getSessionSummary() Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com> Agent-Logs-Url: https://github.com/andrew-nkhoma/fineract/sessions/bc25f20e-fc47-45f8-a71e-d20a9a27f071
…ansaction-types Fix: align closeSession() variance calculation with getSessionSummary() txn type sets
…resolves #43) Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com> Agent-Logs-Url: https://github.com/andrew-nkhoma/fineract/sessions/234a5797-fe73-47a7-b483-facfb6124f39
…om-dotransactionforcashier chore: remove dead entityType code block from doTransactionForCashier() (resolves #43)
…Cashier Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com> Agent-Logs-Url: https://github.com/andrew-nkhoma/fineract/sessions/850c6761-b280-445a-9a7d-cd1adf6b67c4
…allocate-cash Add pre-validation to allocateCashToCashier to match settleCashFromCashier pattern
…Handler Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com> Agent-Logs-Url: https://github.com/andrew-nkhoma/fineract/sessions/e054108a-405d-494e-9513-1e1aa6882def
…e-platform-service Remove CashierWritePlatformService stub and dead ModifyCashierCommandHandler
…ation for new permission codes Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com> Agent-Logs-Url: https://github.com/andrew-nkhoma/fineract/sessions/fc897cb5-3173-4071-8a4c-5d70f037afab
…-permissions Add permission checks to CashierSessionApiResource endpoints
- CashierSessionReadPlatformServiceImpl: replace List.of(1, 101, 102) and List.of(2, 201, 202) with CashierTxnType.ALLOCATE/SETTLE/INWARD_CASH_TXN and OUTWARD_CASH_TXN constants; update explanatory comments - TellerManagementReadPlatformServiceImpl: replace hardcoded 101, 103, 104 literals in cashierTxnSummarySchema() SQL with CashierTxnType enum values; annotate remaining 105 (unclassified) with comment Closes #47 Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com> Agent-Logs-Url: https://github.com/andrew-nkhoma/fineract/sessions/705d2960-89ae-431e-8a31-d4a1e9434cd4
…-transaction-types Replace hardcoded txn_type integers with CashierTxnType enum constants
… (issue #48) Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com> Agent-Logs-Url: https://github.com/andrew-nkhoma/fineract/sessions/63e307f7-b58e-4df6-afd7-c3c4b9518591
…y-parameter Add optional sessionId query parameter to summaryandtransactions endpoint
Agent-Logs-Url: https://github.com/andrew-nkhoma/fineract/sessions/d4ef6e14-ecdd-4bc3-b40f-294069cff1d0 Co-authored-by: andrew-nkhoma <95112149+andrew-nkhoma@users.noreply.github.com>
…entry-reversal Fix manual journal entry reversal to stop creating new offsetting entries
Contributor
|
@andrew-nkhoma ... missing reference to a Jira ticket in the PR title! (waaaaayyy) too many commits, please squash into 1. What problem are you trying to solve here? Seems like most of this was done by some AI tool... and it seems you have a bunch of unresolved conflicts. Can't really identify what kind of solution you are trying here to find... for that the number of changed files is too high (60+), and the changes are all over the place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.