Skip to content

FINERACT-2525: Accept MariaDB snapshot isolation conflict responses in savings integration tests#5763

Open
udayagiri-sivasai-dev wants to merge 3 commits intoapache:developfrom
udayagiri-sivasai-dev:FINERACT-2525
Open

FINERACT-2525: Accept MariaDB snapshot isolation conflict responses in savings integration tests#5763
udayagiri-sivasai-dev wants to merge 3 commits intoapache:developfrom
udayagiri-sivasai-dev:FINERACT-2525

Conversation

@udayagiri-sivasai-dev
Copy link
Copy Markdown

What changed

  • Updated SavingsAccountTransactionTest to accept MariaDB 12.2 snapshot-isolation conflict responses that return 403 with "Record has changed since last read".

Why

  • Under MariaDB 12.2 with innodb_snapshot_isolation=ON, concurrency tests can return a different valid conflict response than the tests previously allowed.

How I tested

  • :integration-tests:test --tests "*SavingsAccountTransactionTest.testDeadlockSavingsBatchTransactions"
  • :integration-tests:test --tests "*SavingsAccountTransactionTest.testConcurrentSavingsBatchTransactions"
  • :integration-tests:test --tests "*SavingsAccountTransactionTest"

@San-43
Copy link
Copy Markdown
Contributor

San-43 commented Apr 12, 2026

Please sign your commits as described in the CONTRIBUTING.md signing guide.

@udayagiri-sivasai-dev udayagiri-sivasai-dev force-pushed the FINERACT-2525 branch 2 times, most recently from 659a44f to 36ead12 Compare April 13, 2026 01:00
@adamsaghy
Copy link
Copy Markdown
Contributor

gradle/actions: Writing build results to /home/runner/work/_temp/.gradle-actions/build-results/__run-1776850844187.json
FAILURE: Build failed with an exception.


[Incubating] Problems report is available at: file:///home/runner/work/fineract/fineract/build/reports/problems/problems-report.html
* What went wrong:

Execution failed for task ':fineract-core:checkstyleMain'.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
> A failure occurred while executing org.gradle.api.plugins.quality.internal.CheckstyleAction

   > Checkstyle rule violations were found. See the report at: file:///home/runner/work/fineract/fineract/fineract-core/build/reports/checkstyle/main.html
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
     Checkstyle files with violations: 1

     Checkstyle violations by severity: [error:1]

Please run:
./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest
./gradlew --no-daemon build -x test -x cucumber -x doc

Before any PR or changes, please always run these two commands and make sure there is green build!

@udayagiri-sivasai-dev
Copy link
Copy Markdown
Author

I addressed the review comment, resolved the conversation, and fixed the Spotless formatting issue. The latest CI run has all 43 checks passing now. Please review when you get a chance.

@udayagiri-sivasai-dev
Copy link
Copy Markdown
Author

I checked the failed API compatibility log. The failing task is :fineract-provider:checkBreakingChanges.

The report is showing several unrelated /v1/self/... endpoints as deleted, such as /v1/self/accounttransfers, /v1/self/authentication, and /v1/self/clients. I don’t think these are related to this PR, since my change is limited to handling the MariaDB snapshot isolation conflict response in the savings integration tests.

The GraphQL “Resource not accessible by integration (addComment)” message also looks like the bot failed to post the report as a PR comment, not the actual root cause.

Could someone confirm whether this API compatibility failure is related to this PR, or if it is coming from the generated OpenAPI comparison/baseline in CI?

@adamsaghy
Copy link
Copy Markdown
Contributor

@udayagiri-sivasai-dev Would you try to rebase this PR with latest develop branch changes? Hopefully that would fix the failing check.

@udayagiri-sivasai-dev
Copy link
Copy Markdown
Author

Rebased the PR with the latest develop branch changes and pushed the updated branch..

@udayagiri-sivasai-dev Would you try to rebase this PR with latest develop branch changes? Hopefully that would fix the failing check.

Rebased the PR with the latest develop branch changes and pushed the updated branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants