FINERACT-2525: Accept MariaDB snapshot isolation conflict responses in savings integration tests#5763
Conversation
|
Please sign your commits as described in the CONTRIBUTING.md signing guide. |
659a44f to
36ead12
Compare
36ead12 to
009c275
Compare
Please run: Before any PR or changes, please always run these two commands and make sure there is green build! |
009c275 to
1943c16
Compare
|
I addressed the review comment, resolved the conversation, and fixed the Spotless formatting issue. The latest CI run has all 43 checks passing now. Please review when you get a chance. |
|
I checked the failed API compatibility log. The failing task is :fineract-provider:checkBreakingChanges. The report is showing several unrelated /v1/self/... endpoints as deleted, such as /v1/self/accounttransfers, /v1/self/authentication, and /v1/self/clients. I don’t think these are related to this PR, since my change is limited to handling the MariaDB snapshot isolation conflict response in the savings integration tests. The GraphQL “Resource not accessible by integration (addComment)” message also looks like the bot failed to post the report as a PR comment, not the actual root cause. Could someone confirm whether this API compatibility failure is related to this PR, or if it is coming from the generated OpenAPI comparison/baseline in CI? |
|
@udayagiri-sivasai-dev Would you try to rebase this PR with latest |
abe6986 to
da0aff2
Compare
|
Rebased the PR with the latest develop branch changes and pushed the updated branch..
Rebased the PR with the latest develop branch changes and pushed the updated branch. |
What changed
Why
How I tested