fix(radar): respect axisName width and overflow#21676
Open
jesco-absolut wants to merge 1 commit into
Open
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Allow radar indicator axis names to respect configured
axisName.widthandaxisName.overflowinstead of always using the internal truncate fallback.Fixed issues
widthandoverflowsettings were not taking effect.Details
Before: What was the problem?
Radar indicator names are rendered through the shared axis-name builder. That builder always passed
overflow: 'truncate'andwidth: maxWidthas fixed style values for axis names, so user-provided radaraxisNametext style options such as:were overwritten before reaching the ZRender text element. In an SSR reproduction, long radar indicator labels remained a single SVG
<text>element even withwidth: 50andoverflow: 'break'.After: How does it behave after the fixing?
Axis-name rendering now uses
nameTextStyle/ radaraxisNameoverflowandwidthwhen they are provided, while preserving the existing truncate fallback when they are not. Withwidth: 50andoverflow: 'break', the SSR output now emits multiple text lines for long radar indicator labels.A focused visual case was added to
test/radar-axis.htmlto cover long radar indicator names wrapping within50px.Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/radar-axis.htmlMerging options
Other information
Validation run locally:
npx eslint src/component/axis/AxisBuilder.tsnpm run checktypegit diff --checknpm run build:lib && npm run buildnpm run build:lib && npm run buildgenerated build outputs locally for validation only; generated files were reverted and are not included in this PR.