fix(tooltip): apply textStyle in richText formatter#21675
Open
jesco-absolut wants to merge 1 commit into
Open
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Apply tooltip
textStylefont and text-border options to richText tooltip content when a formatter returns plain text.Fixed issues
tooltip.textStylewas not fully applied whentooltip.renderModewasrichTextandformatterwas used.Details
Before: What was the problem?
When a tooltip used
renderMode: 'richText'with a formatter such asformatter: 'Data: {c}', the formatter output was rendered as the root ZRender text element.TooltipRichContentonly copied a small subset oftooltip.textStyleto that root richText element, so options such asfontStyle,fontWeight,fontFamily, and text border settings were ignored even though the same style intent works in HTML tooltip mode.After: How does it behave after the fixing?
The richText tooltip root text style now applies the relevant
tooltip.textStylefields directly, including font style, weight, size, family, line height, text shadow offsets/blur, and text border color/width. The existingtest/tooltip-textStyle.htmlrichText formatter case was extended to cover bold italic monospace text with a text border.Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/tooltip-textStyle.htmlMerging options
Other information
Validation run locally:
npx eslint src/component/tooltip/TooltipRichContent.tsnpm run checktypegit diff --checknpm run buildnpm run buildgenerateddist/files locally for validation only; they were reverted and are not included in this PR.