fix(axis): respect custom axis tick interval. close #17967#21671
Open
rahul37wallst-sudo wants to merge 1 commit into
Open
fix(axis): respect custom axis tick interval. close #17967#21671rahul37wallst-sudo wants to merge 1 commit into
rahul37wallst-sudo wants to merge 1 commit into
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix category axis ticks so
axisTick.intervalcallback results are respected exactly.Fixed issues
axisTick.intervalcallback did not select them.Details
Before: What was the problem?
When
xAxis.axisTick.intervalwas a callback on a category axis, ECharts still kept extent-boundary ticks internally.That caused two incorrect cases:
After: How does it behave after the fixing?
Function-based
axisTick.intervalnow keeps ticks strictly according to the callback result.The min/max boundary preservation remains for axis labels, where the existing label display strategy needs it, but custom axis tick callbacks no longer receive forced boundary ticks.
Validation:
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
Added regression coverage in
test/ut/spec/scale/interval.test.ts.Merging options
Other information
N.A.