fix: honor pie label.alignTo='labelLine' when label.position='outside'#21618
Open
mvanhorn wants to merge 1 commit into
Open
fix: honor pie label.alignTo='labelLine' when label.position='outside'#21618mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
The pie label layout pass at labelLayout.ts:137 only checked list[i].position === 'outer'. The rest of the pipeline normalizes 'outside' to 'outer' as an alias, so labels with position 'outside' were silently bypassing the labelLine alignment branch. Fixes apache#21617
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a pie chart series sets
label.positionto'outside'(an alias for'outer') andlabel.alignToto'labelLine', the labelLine alignment pass was being silently bypassed. The fix is a 2-line change to also match'outside'atlabelLayout.ts:137.Why this matters
The rest of the pie label pipeline treats
outsideandouteras the same position value. The labelLayout alignment branch is the one place that hardcoded just'outer', so users settingposition: 'outside'(the documented alias) saw misaligned label lines whileposition: 'outer'worked correctly. Reporter pinpointed the exact line.Changes
src/chart/pie/labelLayout.ts- widen the position check to accept both'outer'and'outside'inadjustSingleSide.test/ut/spec/series/pie.test.ts- add a regression test that asserts both'outer'and'outside'produce identical labelLine layouts whenalignTo: 'labelLine'.Testing
npm run test:ut -- pie.test(Karma + Jasmine).Fixes #21617