[fix](publish) Avoid NPE for force-finished publish task#63069
Open
deardeng wants to merge 2 commits intoapache:masterfrom
Open
[fix](publish) Avoid NPE for force-finished publish task#63069deardeng wants to merge 2 commits intoapache:masterfrom
deardeng wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
FE publish can loop on: java.lang.NullPointerException: Cannot invoke "java.util.Map.containsKey(Object)" because the return value of "PublishVersionTask.getSuccTablets()" is null at DatabaseTransactionMgr.checkReplicaContinuousVersionSucc(...) at DatabaseTransactionMgr.finishCheckQuorumReplicas(...) at DatabaseTransactionMgr.finishTransaction(...) PublishVersionTask starts with succTablets == null, but AgentTaskCleanupDaemon.removeInactiveBeAgentTasks can force-finish an in-flight task with setFinished(true) without ever calling setSuccTablets. That leaves a finished task whose getSuccTablets() still returns null. MasterImpl.finishPublishVersion is only a theoretical source here: BE task_worker_pool.cpp unconditionally sets succ_tablets on the finish request, so that path currently receives at worst an empty map. Fix this on both sides: - default PublishVersionTask.succTablets to an empty map and coerce null - guard the call site before containsKey(tabletId) Add FE unit coverage and a regression suite for BE-down publish cleanup.
dfec873 to
479a4a0
Compare
Collaborator
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FE publish can loop on:
PublishVersionTask starts with succTablets == null, but
AgentTaskCleanupDaemon.removeInactiveBeAgentTasks can force-finish an
in-flight task with setFinished(true) without ever calling setSuccTablets.
That leaves a finished task whose getSuccTablets() still returns null.
MasterImpl.finishPublishVersion is only a theoretical source here:
BE task_worker_pool.cpp unconditionally sets succ_tablets on the finish
request, so that path currently receives at worst an empty map.
Fix this on both sides:
Add FE unit coverage and a regression suite for BE-down publish cleanup.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)